Add permission based chest placement limits by YouSeeMeRunning2 · Pull Request #292 · BG-Software-LLC/WildChests

YouSeeMeRunning2 · 2025-09-20T12:18:57Z

Added wildchests.limit.. permission system
Added default-chest-limits config section (0=unlimited, 1+=limited, -1=disabled)
Added enable-chest-limits config option (default: false)
Added limit enforcement in BlockListener with lang messages
Added ChestLimitUtils for permission and config limit checking
Added getChestCount() method to ChestsManager API
Fixed v1_21_5 NMS compatibility issues (might of been an issue in my project only)

- Added wildchests.limit.<type>.<amount> permission system - Added default-chest-limits config section (0=unlimited, 1+=limited, -1=disabled) - Added enable-chest-limits config option (default: false) - Added limit enforcement in BlockListener with lang messages - Added ChestLimitUtils for permission and config limit checking - Added getChestCount() method to ChestsManager API - Fixed v1_21_5 NMS compatibility issues (might of been an issue in my project only)

OmerBenGera · 2025-09-28T18:24:42Z


 dependencies {
-    paperweight.paperDevBundle("1.21.5-R0.1-SNAPSHOT")
+    paperweight.paperDevBundle("1.21.4-R0.1-SNAPSHOT")


Why did you downgrade the version?

OmerBenGera · 2025-09-28T18:25:09Z

The changes in this file are only because you downgraded the version

OmerBenGera · 2025-09-28T18:25:41Z

 include 'NMS:v1_21_3'
 include 'NMS:v1_21_4'
-include 'NMS:v1_21_5'
+// include 'NMS:v1_21_5'  // Temporarily disabled due to API incompatibilities


OmerBenGera · 2025-09-28T18:26:07Z

+                .filter(chest -> chest.getPlacer().equals(placer))
+                .filter(chest -> chest.getData().getName().equals(chestType))


Combine both filters to a single predicate

OmerBenGera · 2025-09-28T18:27:06Z

+                .filter(chest -> chest.getPlacer().equals(placer))
+                .filter(chest -> chest.getData().getName().equals(chestType))


Instead of comparing the names of the chestType, get the chest data of the provided chestType and check if they are equal with ==

OmerBenGera · 2025-09-28T18:27:16Z

    }

+    @Override
+    public int getChestCount(UUID placer, String chestType) {


chestType -> chestDataName

OmerBenGera · 2025-09-28T18:29:12Z

+# Enable permission-based chest placement limits.
+# When enabled, players can only place a limited number of each chest type based on permissions.
+# Permission format: wildchests.limit.<type>.<amount>
+# For example: wildchests.limit.linked_chest.5 allows placing up to 5 linked chests
+enable-chest-limits: false
+
+# Default limits for each chest type when no specific permission is given.
+# Set to 0 for unlimited, or any positive number for the default limit.
+# Set to -1 to disable this chest type entirely.
+# These only apply when enable-chest-limits is true.
+default-chest-limits:
+  linked_chest: 0
+  large_chest: 0
+  sell_chest: 0
+  auto_crafter: 0
+  storage_unit: 0
+  chunk_collector: 0
+


Change this to:

chest-limits: enabled: false default: - ...

OmerBenGera · 2025-09-28T18:29:57Z

+
+    private ChestLimitUtils() {}
+
+    public static int getPlayerChestLimit(Player player, String chestType) {


Calling hasPlayerChestLimit and then getPlayerChestLimit are really expensive calls (in terms of performance). Optimize this

- Chest placement limits functionality

OmerBenGera · 2025-10-14T10:19:03Z

+    /**
+     * Result class to hold both limit existence and value information
+     */
+    public static class ChestLimitResult {


Rename to Result and move this down, below the method to check for limit

OmerBenGera · 2025-10-14T10:19:14Z

+        }
+    }
+
+    public static ChestLimitResult getPlayerChestLimitResult(Player player, String chestDataName) {


Rename to checkChestLimit

OmerBenGera · 2025-10-14T10:21:06Z

+
+        Integer defaultLimit = WildChestsPlugin.getPlugin().getSettings().defaultChestLimits.get(chestDataName);
+        if (defaultLimit != null && defaultLimit != -1) {
+            int actualLimit = defaultLimit == 0 ? Integer.MAX_VALUE : defaultLimit;


You should support limit 0 - this means players won't be able to place that chest
Instead, check if the limit is non-negative.

OmerBenGera · 2025-10-14T10:22:16Z

Revert changes

OmerBenGera · 2025-10-14T10:22:20Z

Revert changes

OmerBenGera · 2025-10-14T10:22:24Z

Revert changes

OmerBenGera requested changes Sep 28, 2025

View reviewed changes

YouSeeMeRunning2 and others added 2 commits October 4, 2025 11:43

- Update ChestLimitUtils parameter name from chestType to chestDataName

d9e5615

- Chest placement limits functionality

Update settings.gradle

2374838

YouSeeMeRunning2 requested a review from OmerBenGera October 4, 2025 17:34

OmerBenGera requested changes Oct 14, 2025

View reviewed changes

		.filter(chest -> chest.getPlacer().equals(placer))
		.filter(chest -> chest.getData().getName().equals(chestType))


		private ChestLimitUtils() {}

		public static int getPlayerChestLimit(Player player, String chestType) {

Uh oh!

Conversation

YouSeeMeRunning2 commented Sep 20, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants